Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#19195] fix: communities design issues #19819

Merged
merged 1 commit into from
May 7, 2024
Merged

[#19195] fix: communities design issues #19819

merged 1 commit into from
May 7, 2024
+3 −2

Conversation

mohsen-ghafouri
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri commented Apr 26, 2024 •
edited
Loading

fixes #19195

Summary

  • Margin [comment] between top nav and community avatar is too narrow [might be caused to the issue below ⤵️]
  • Avatar is too big [comment]
  • Avatar image quality is poor [comment] even though the original image is a 1080px square
  • Margin is too narrow [comment] between the Join button and the channel list

Areas that maybe impacted

  • Community overview

Steps to test

  • Open a Status community you're not a member of

Result

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Apr 26, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Apr 26, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8e07832 #1 2024-04-26 21:23:43 ~4 min tests 📄log
✔️ 8e07832 #1 2024-04-26 21:27:41 ~8 min ios 📱ipa 📲
✔️ 8e07832 #1 2024-04-26 21:29:46 ~10 min android-e2e 🤖apk 📲
✔️ 8e07832 #1 2024-04-26 21:29:47 ~10 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 08407ab #3 2024-05-01 17:34:22 ~4 min tests 📄log
✔️ 08407ab #3 2024-05-01 17:35:18 ~5 min android-e2e 🤖apk 📲
✔️ 08407ab #3 2024-05-01 17:36:27 ~7 min android 🤖apk 📲
✔️ 08407ab #3 2024-05-01 17:37:52 ~8 min ios 📱ipa 📲
✔️ 6809fdf #4 2024-05-07 10:16:00 ~5 min tests 📄log
✔️ 6809fdf #4 2024-05-07 10:16:06 ~5 min android 🤖apk 📲
✔️ 6809fdf #4 2024-05-07 10:18:28 ~8 min ios 📱ipa 📲
✔️ 6809fdf #4 2024-05-07 10:19:27 ~9 min android-e2e 🤖apk 📲

@mohsen-ghafouri mohsen-ghafouri force-pushed the fix/communities-design-issues branch 2 times, most recently from 3e4621a to 08407ab Compare May 1, 2024 17:29
@mohsen-ghafouri mohsen-ghafouri marked this pull request as ready for review May 1, 2024 17:29
@status-im-auto
Copy link
Member

92% of end-end tests have passed

Total executed tests: 52
Failed tests: 3
Expected to fail tests: 1
Passed tests: 48

IDs of failed tests: 727230,727229,703391 

IDs of expected to fail tests: 703503

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find `WalletTab` by `accessibility id`: `wallet-stack-tab` 

    critical/test_wallet.py:117: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:39: in _get_balances_before_tx
    self.wallet_1.wallet_tab.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track'] 

    critical/test_wallet.py:109: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:97: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:84: in confirm_transaction
    self.slide_and_confirm_with_password()
../views/wallet_view.py:78: in slide_and_confirm_with_password
    self.slide_button_track.slide()
../views/base_view.py:257: in slide
    self.swipe_right_on_element(width_percentage=1.3, start_x=100)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_send_image_save_and_share, id: 703391

    Device 2: Find Button by accessibility id: image-0
    Device 2: Click system back button 

    critical/chats/test_1_1_public_chats.py:458: in test_1_1_chat_send_image_save_and_share
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Not expected image is shown to the receiver.



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (48)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    6. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    @mohsen-ghafouri
    Copy link
    Contributor Author

    @status-im/mobile-qa could you please check test results? thanks

    @status-im-auto
    Copy link
    Member

    0% of end-end tests have passed

    Total executed tests: 3
Failed tests: 3
Expected to fail tests: 0
Passed tests: 0

    IDs of failed tests: 727230,703391,727229

    Failed tests (3)

    Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_send_image_save_and_share, id: 703391

    Device 2: Find `Button` by `accessibility id`: `image-0`
    Device 2: Click system back button 

    critical/chats/test_1_1_public_chats.py:458: in test_1_1_chat_send_image_save_and_share
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Not expected image is shown to the receiver.



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 1: Long press on AssetElement
    Device 1: Find EditBox by accessibility id: address-text-input 

    critical/test_wallet.py:123: in test_wallet_send_asset_from_drawer
    self.wallet_1.send_asset_from_drawer(address=self.receiver['address'], asset_name='Ether',
../views/wallet_view.py:104: in send_asset_from_drawer
    self.address_text_input.send_keys(address)
../views/base_element.py:377: in send_keys
    self.find_element().send_keys(value)
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: EditBox by accessibility id: `address-text-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]
    Device 2: Text is 0.0334 ETH 

    critical/test_wallet.py:112: in test_wallet_send_eth
    self._check_balances_after_tx(amount_to_send, sender_balance, receiver_balance, eth_amount_sender,
critical/test_wallet.py:98: in _check_balances_after_tx
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Eth amount in the senders wallet is 0.0372 but should be 0.0371
E    Eth amount in the receivers wallet is 0.0334 but should be 0.0335



    @yevh-berdnyk
    Copy link
    Contributor

    hi @mohsen-ghafouri e2e failures are not PR related, thanks!

    @mohsen-ghafouri
    Copy link
    Contributor Author

    Hi @Francesca-G, could you please review it?

    Francesca-G
    Francesca-G approved these changes May 7, 2024
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Issues look fixed ✨

    @mohsen-ghafouri mohsen-ghafouri force-pushed the fix/communities-design-issues branch from 08407ab to 6809fdf Compare May 7, 2024 10:09
    @mohsen-ghafouri mohsen-ghafouri merged commit 7ec77db into develop May 7, 2024
    6 checks passed
    @mohsen-ghafouri mohsen-ghafouri deleted the fix/communities-design-issues branch May 7, 2024 10:20
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Francesca-G Francesca-G Francesca-G approved these changes

    @jo-mut jo-mut jo-mut approved these changes

    @BalogunofAfrica BalogunofAfrica Awaiting requested review from BalogunofAfrica

    @ajayesivan ajayesivan Awaiting requested review from ajayesivan

    Assignees

    @mohsen-ghafouri mohsen-ghafouri

    Labels
    design-review-required skip-manual-qa
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Communities - Community screen issues
    5 participants
    @mohsen-ghafouri @status-im-auto @yevh-berdnyk @jo-mut @Francesca-G